From 1553825719ae0f6230cdd29f22786d553b07b6dc Mon Sep 17 00:00:00 2001 From: Sebin Nyshkim Date: Tue, 5 Sep 2023 22:49:23 +0200 Subject: [PATCH 1/5] refactor: add type definition for emits --- src/components/LocaleSwitcher.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/LocaleSwitcher.vue b/src/components/LocaleSwitcher.vue index ab21fbd..d86d7cb 100644 --- a/src/components/LocaleSwitcher.vue +++ b/src/components/LocaleSwitcher.vue @@ -15,8 +15,12 @@ interface Props { locales: LocaleOption[] } +interface Emits { + (e: 'update:modelValue', value: string): void +} + const props = defineProps() -const emit = defineEmits(['update:modelValue']) +const emit = defineEmits() const selectModel = computed({ get() { From f67ba1e65526e2ccc1766da71cf55cbad461969c Mon Sep 17 00:00:00 2001 From: Sebin Nyshkim Date: Wed, 6 Sep 2023 00:17:27 +0200 Subject: [PATCH 2/5] refactor: get routes via getRoutes() function instead of importing router config --- src/App.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/App.vue b/src/App.vue index c48ef1c..15f03e7 100644 --- a/src/App.vue +++ b/src/App.vue @@ -2,7 +2,6 @@ import { ref } from 'vue' import { RouterView } from 'vue-router' import { version } from '../package.json' -import router from '@/router' import ModalDialog from '@/components/ModalDialog.vue' import LocaleSwitcher from '@/components/LocaleSwitcher.vue' @@ -46,7 +45,7 @@ const close = () => { Date: Wed, 6 Sep 2023 00:17:56 +0200 Subject: [PATCH 3/5] style: close component tag immediately --- src/components/NavigationItem.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/NavigationItem.vue b/src/components/NavigationItem.vue index e34facd..8878b63 100644 --- a/src/components/NavigationItem.vue +++ b/src/components/NavigationItem.vue @@ -11,7 +11,7 @@ defineProps()