refactor: ♻️ use more appropriate elements for semantics

This commit is contained in:
Sebin Nyshkim 2025-04-09 19:05:09 +02:00
parent 10a971c621
commit 7bd2440556
3 changed files with 18 additions and 14 deletions

View file

@ -1,12 +1,12 @@
<div class="character-colors"> <ul class="character-colors">
<div class="color" webc:for="color of colors"> <li class="color" webc:for="color of colors">
<div class="color-box" @attributes="({ style: `background-color: ${color.value}`})"></div> <div class="color-box" @attributes="({ style: `background-color: ${color.value}`})"></div>
<div class="content"> <div class="content">
<p class="heading" @text="color.name"></p> <p class="heading" @text="color.name"></p>
<p class="text" @text="color.value"></p> <p class="text" @text="color.value"></p>
</div> </div>
</div> </li>
</div> </ul>
<style> <style>
.character-colors { .character-colors {
@ -17,6 +17,7 @@
gap: 1em; gap: 1em;
margin-block: 2em; margin-block: 2em;
padding: 0;
& .color { & .color {
display: grid; display: grid;

View file

@ -1,10 +1,10 @@
<div class="timeline"> <ul class="timeline">
<div class="job" webc:for="job of jobs"> <li class="job" webc:for="job of jobs">
<icon class="icon" :icon="job.icon"></icon> <icon class="icon" :icon="job.icon"></icon>
<p class="title" @text="job.title"></p> <p class="title" @text="job.title"></p>
<p class="text" @text="job.desc"></p> <p class="text" @text="job.desc"></p>
</div> </li>
</div> </ul>
<style> <style>
.timeline { .timeline {
@ -13,6 +13,9 @@
--timeline-stroke-color: var(--clr-timeline-stroke); --timeline-stroke-color: var(--clr-timeline-stroke);
--timeline-stroke-thickness: calc(var(--timeline-circle-size) / 16); --timeline-stroke-thickness: calc(var(--timeline-circle-size) / 16);
margin-block: 1em;
padding: 0;
@media (min-width: 32em) { @media (min-width: 32em) {
--timeline-circle-size: 4rem; --timeline-circle-size: 4rem;
} }

View file

@ -1,10 +1,10 @@
<div class="trait-list"> <ul class="trait-list">
<div class="trait" webc:for="trait of traits"> <li class="trait" webc:for="trait of traits">
<div class="icon-box"><icon :icon="trait.icon" webc:nokeep></icon></div> <div class="icon-box"><icon :icon="trait.icon" webc:nokeep></icon></div>
<p class="type" @text="trait.type"></p> <p class="type" @text="trait.type"></p>
<p class="text" @text="trait.text"></p> <p class="text" @text="trait.text"></p>
</div> </li>
</div> </ul>
<style> <style>
.trait-list { .trait-list {
@ -12,8 +12,8 @@
grid-template-columns: repeat(auto-fit, minmax(10em, 1fr)); grid-template-columns: repeat(auto-fit, minmax(10em, 1fr));
gap: 0.75em; gap: 0.75em;
margin-block: 0; margin: 0;
margin-inline: 0; padding: 0;
} }
.trait { .trait {